Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] sort-prop-types: avoid crash when autofixing #3471

merged 1 commit into from Nov 27, 2022


Copy link

Fixes #3470

Now rule respects multiple comments before and after prop.
Fixes issue of no comments before and after prop not being considered during parsing.

Copy link

ljharb commented Nov 16, 2022

@ROSSROSALES i think this needs to be rebased on latest, and i'm not sure of the best way to do it. Can you give it a try?

Copy link
Contributor Author

I'll give it a try to rebase on latest

Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #3471 (1ee5db8) into master (dfd64ae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1ee5db8 differs from pull request most recent head cc9578c. Consider uploading reports for the commit cc9578c to get more accurate results

@@           Coverage Diff           @@
##           master    #3471   +/-   ##
  Coverage   97.57%   97.57%           
  Files         129      129           
  Lines        9212     9214    +2     
  Branches     3342     3341    -1     
+ Hits         8989     8991    +2     
  Misses        223      223           
Impacted Files Coverage Δ
lib/rules/sort-prop-types.js 98.27% <ø> (ø)
lib/util/propTypesSort.js 98.76% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ljharb ljharb force-pushed the master branch 4 times, most recently from 069314a to 181c68f Compare November 18, 2022 17:19
@ljharb ljharb force-pushed the ross-fix-sort-props-#3470 branch 2 times, most recently from 8799c44 to 668d54f Compare November 27, 2022 06:08
Copy link

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty good if tests pass.

@ljharb ljharb changed the title [Fix] sort-prop-types #3470 [Fix] sort-prop-types: avoid crash when autofixing Nov 27, 2022
@ljharb ljharb merged commit cc9578c into jsx-eslint:master Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Results of weekly scheduled smoke test
2 participants