Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: inclusive language w/ allowlist #3473

Merged
merged 1 commit into from Oct 26, 2022

Conversation

AndersDJohnson
Copy link
Contributor

Hello! Love this plugin! Just noticed an opportunity to make the language a bit more inclusive in the docs for the rule forbid-component-props by switching to the term "allowlist", as other projects have been doing lately. Up to the maintainers though! Thanks.

Side note: Have we considered opting this repository into Hacktoberfest? Simply adding the hacktoberfest topic to the repo will allow contributors to get credit for their changes! https://hacktoberfest.com/participation/ Thanks again!

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #3473 (b2ef5e9) into master (88cbcde) will not change coverage.
The diff coverage is n/a.

Current head b2ef5e9 differs from pull request most recent head 64f9266. Consider uploading reports for the commit 64f9266 to get more accurate results

@@           Coverage Diff           @@
##           master    #3473   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files         129      129           
  Lines        9192     9192           
  Branches     3331     3331           
=======================================
  Hits         8969     8969           
  Misses        223      223           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ljharb
ljharb approved these changes Oct 26, 2022
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; this is more consistent with allowedFor anyways.

@ljharb
Copy link
Member

ljharb commented Oct 26, 2022

Regarding hacktoberfest, adding the topic attracts way too much spam, so I add the "hacktoberfest-accepted" label to PRs manually so contributors can get credit.

@ljharb ljharb added documentation hacktoberfest-accepted If you're interested in a free shirt, this PR counts towards it. labels Oct 26, 2022
@ljharb ljharb merged commit 64f9266 into jsx-eslint:master Oct 26, 2022
4 of 6 checks passed
@AndersDJohnson AndersDJohnson deleted the patch-1 branch Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation hacktoberfest-accepted If you're interested in a free shirt, this PR counts towards it.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants