Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] jsx-no-leaked-render: removing parentheses for conditionals #3502


Copy link

@akulsr0 akulsr0 commented Dec 5, 2022

Fixes #3498

Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #3502 (7fcbd9f) into master (c9f5eb2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7fcbd9f differs from pull request most recent head 8b51eef. Consider uploading reports for the commit 8b51eef to get more accurate results

@@           Coverage Diff           @@
##           master    #3502   +/-   ##
  Coverage   97.57%   97.57%           
  Files         130      130           
  Lines        9211     9213    +2     
  Branches     3341     3342    +1     
+ Hits         8988     8990    +2     
  Misses        223      223           
Impacted Files Coverage Δ
lib/rules/jsx-no-leaked-render.js 98.55% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the test fails prior to your fix, and passes afterwards, this looks great, thanks!

@ljharb ljharb force-pushed the fix/jsx-no-leaked-render-removing-paranthesis branch from 7fcbd9f to 8b51eef Compare December 15, 2022 17:09
@ljharb ljharb closed this in 8b51eef Dec 15, 2022
@ljharb ljharb merged commit 8b51eef into jsx-eslint:master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

jsx-no-leaked-render causes code to be incorrect by removing parentheses
2 participants