Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] no-unknown-property: add fill for <marker> #3525

Merged
merged 1 commit into from Jan 24, 2023
Merged

[Fix] no-unknown-property: add fill for <marker> #3525

merged 1 commit into from Jan 24, 2023

Conversation

alexey-koran
Copy link
Contributor

@alexey-koran alexey-koran commented Jan 24, 2023

Similar to #3416 but for fill of marker

https://developer.mozilla.org/en-US/docs/Web/SVG/Element/marker

error  Invalid property 'fill' found on tag 'marker', but it is only allowed on: altGlyph, circle, ellipse, g, line, mask, path, polygon, polyline, rect, svg, text, textPath, tref, tspan, use, animate, animateColor, animateMotion, animateTransform, set  react/no-unknown-property

<marker fill='#000' />

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #3525 (14e315a) into master (4523e73) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3525   +/-   ##
=======================================
  Coverage   97.58%   97.58%           
=======================================
  Files         131      131           
  Lines        9236     9236           
  Branches     3358     3358           
=======================================
  Hits         9013     9013           
  Misses        223      223           
Impacted Files Coverage Δ
lib/rules/no-unknown-property.js 98.82% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit 14e315a into jsx-eslint:master Jan 24, 2023
263 checks passed
@ljharb ljharb changed the title [Fix] no-unknown-property fill for marker [Fix] no-unknown-property: add fill for <marker> Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants