New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fx17 bugfix breaks NoSquint 2.1.5 #38

Closed
streetwolf opened this Issue Aug 8, 2012 · 10 comments

Comments

Projects
None yet
3 participants
@streetwolf
Copy link

streetwolf commented Aug 8, 2012

Seems that something in the hourly http://hg.mozilla.org/mozilla-central/rev/b99a81e70b06 totally screws up NoSquint. Can't set zoom per site anymore. Once you set a site's zoom all sites use the same one.

@streetwolf

This comment has been minimized.

Copy link

streetwolf commented Aug 9, 2012

Alice0775 suggested this change which did fix the problem.

Change line 417 in chrome\nosquint.jar\content\browser.js as follows

browser.addProgressListener(listener);

@streetwolf streetwolf closed this Aug 9, 2012

@streetwolf streetwolf reopened this Aug 9, 2012

@g2p

This comment has been minimized.

Copy link

g2p commented Aug 10, 2012

Here are the docs, but they might need updating (they refer to a feature that might have been silently broken if dao's comment refers to the <browser> case, before the current more noticeable change).

@ghost ghost assigned jtackaberry Aug 10, 2012

@jtackaberry

This comment has been minimized.

Copy link
Owner

jtackaberry commented Aug 10, 2012

Thanks guys.

I'd appreciate it if you could give this preview release of 2.1.6 a shot to see if it solves your problem.

@g2p

This comment has been minimized.

Copy link

g2p commented Aug 10, 2012

Works for me. Sites keep their own zoom level, and the domain name is displayed in the per-site properties instead of about:blank.

@streetwolf

This comment has been minimized.

Copy link

streetwolf commented Aug 10, 2012

Jason.

2.1.6 seems to work fine. By chance have you going to allow the percentage amount to be placed in other places other than the add-on bar? I currently use the add-on 'UI Fixer' to move it to my Bookmark Bar since I do not display the add-on/status bar.

From: Jason Tackaberry
Sent: Friday, August 10, 2012 5:58 PM
To: jtackaberry/nosquint
Cc: Gary
Subject: Re: [nosquint] Fx17 bugfix breaks NoSquint 2.1.5 (#38)

Thanks guys.

I'd appreciate it if you could give this preview release of 2.1.6 a shot to see if it solves your problem.


Reply to this email directly or view it on GitHub.

@streetwolf

This comment has been minimized.

Copy link

streetwolf commented Aug 10, 2012

g2p...

If you are using the latest nightly of Fx17 on Windows and NS 2.1.5 works for you then perhaps they backed out the bug fix that introduced the problem or fixed it.

@jtackaberry

This comment has been minimized.

Copy link
Owner

jtackaberry commented Aug 10, 2012

Thanks for confirming guys. I'll issue a release in the next couple of days.

@streetwolf the only change I made in 2.1.6 was fixing this regression. Any enhancements are going into the 3.0 release, which is in development (but it's going slowly, for lack of free time). The specific change you're asking about is coming in 3.0, and is being tracked in issue #4.

@jtackaberry

This comment has been minimized.

Copy link
Owner

jtackaberry commented Aug 10, 2012

I think g2p meant that 2.1.6-rc1 worked for him, not that 2.1.5 started working again. At least that's how I interpreted it. :)

@g2p

This comment has been minimized.

Copy link

g2p commented Aug 10, 2012

@jtackberry, absolutely. That was in answer to your RC.

@streetwolf

This comment has been minimized.

Copy link

streetwolf commented Aug 10, 2012

My bad, sorry

From: g2p
Sent: Friday, August 10, 2012 6:50 PM
To: jtackaberry/nosquint
Cc: Gary
Subject: Re: [nosquint] Fx17 bugfix breaks NoSquint 2.1.5 (#38)

@jtackberry, absolutely. That was in answer to your RC.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment