New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reaticulate is crashed if icon description or color description is wrong #13
Comments
Thanks for the report. Can you share the specific bank definition that triggered the crash? |
Error is:
For example, instead:
you put this for color:
fall is non existent color in your array I suppose. |
Yep, makes sense. Cheers. |
https://github.com/jtackaberry/reaticulate/blob/master/app/articons.lua#L32
Or even you can include undefined icon in your png, so when you handle undefined you should represent icon with question mark for example. |
This is supposed to be handled here: https://github.com/jtackaberry/reaticulate/blob/master/app/reabank.lua#L225 Specifically: local color = art.color or reabank.colors.default
-- [...]
art.icon = articons.get(art.iconname or 'note-eighth') So you can see the intention there. Should be quite an easy fix, really, but I won't be in front of my DAW until tonight. |
Something like: art.icon = articons.get(art.iconname) or articons.get('note-eighth') should do. At first blush, though, not sure why you're seeing problems with the color. Will dig in tonight. |
Scratch that: yes, it's obvious why specifying an invalid color horks. Easy fix there too. |
Hi,
For example, while I'm creating new bank presets and I put some undefined icon, color descriptions, plugin will crash if you reload it.
I would suggest something like (pseudo):
if color.exists? ? parse(color) : 'undefined color'
That way we'll have just "undefined : undefined" on GUI, but we'll avoid crash.
The text was updated successfully, but these errors were encountered: