Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make articulation insertion compatible with undo #47

Closed
Levitanus opened this issue Oct 1, 2018 · 3 comments

Comments

@Levitanus
Copy link

@Levitanus Levitanus commented Oct 1, 2018

I think it's consolidated with something else. When articulation is added by right-clicking, then immediately record starts, and after it undo is used, both, the recorded midi and pr change are removed.

@jtackaberry

This comment has been minimized.

Copy link
Owner

@jtackaberry jtackaberry commented Oct 13, 2018

I can't reproduce this exactly, but there's always not been something quite right about the how Reaper handles undo with Reaticulate. It's something I've wrestled with, and I'm quite convinced there is at least one Reaper bug at play here, because despite neatly wrapping everything in Undo_BeginBlock2() and Undo_EndBlock2(), initiating an undo in Reaper will sometimes undo beyond the point of the Undo_BeginBlock2() call.

@Levitanus

This comment has been minimized.

Copy link
Author

@Levitanus Levitanus commented Oct 13, 2018

Yep, I've also noticed at my scripts)
Still, I found a way of selecting the item between art assignment and record start. Not hard to keep in practice and works

@jtackaberry jtackaberry changed the title Undo point at right-click articulation adding Make articulation insertion compatible with undo Aug 13, 2019
@jtackaberry

This comment has been minimized.

Copy link
Owner

@jtackaberry jtackaberry commented Aug 13, 2019

The redesign described by #62 will open the door to workarounds. I have a proof of concept working in my local tree so I'll tentative plan to fix this in the next major release (0.4.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.