Increase exclusion list. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedloden
suggested changes
Nov 11, 2017
lib/private_address_check.rb
Outdated
| @@ -6,21 +6,37 @@ | |||
| module PrivateAddressCheck | |||
| module_function | |||
|
|
|||
| module PrivateAddressCheck | |||
lib/private_address_check.rb
Outdated
| CIDR_LIST = [ | ||
| # Loopback |
There was a problem hiding this comment.
Please keep comments and segment each addition into specific sections under a comment that explains what it is.
There was a problem hiding this comment.
@reedloden I plan on adding comments in just a bit. On top of that, this PR doesn't even include tests so it isn't ready for merging quite yet.
|
Thoughts, @jtdowney? |
|
Sorry for the delay, for some reason I wasn't getting any notifications from GitHub for this repo. I think this looks good. My only feedback is that the quotes are inconsistent. The rest of the gem uses double quotes so it would be good to do that here. |
|
@jtdowney That should be fixed now. |
|
Thanks! |
|
This is CVE-2017-0909. |
RubenVerborgh
added a commit
to nodeSolidServer/node-solid-server
that referenced
this pull request
Sep 30, 2018
dmitrizagidulin
pushed a commit
to interop-alliance/life-server
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since you are using a blacklist approach, let's make absolutely sure no address can bypass it.