Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC status update #1

Open
katanacrimson opened this issue Jan 22, 2021 · 16 comments
Open

PoC status update #1

katanacrimson opened this issue Jan 22, 2021 · 16 comments

Comments

@katanacrimson
Copy link

....Just in case anyone was wondering, the PoC still works on GOG Galaxy 2.0.35 (last tested as of time of wriitng this). Just compiled and tested it and was able to create a local user and add them to the local administrators group on a testbed system.

GOG has yet to fix the underlying issue, it seems. CVE-2020-24574 is alive and well, yet.

@Wibbbs
Copy link

Wibbbs commented Jan 22, 2021

This makes me really sad. I really really liked the application, but until they take security seriously I don’t want to re-install. I can’t believe how long it has taken them to fix this. Unless of course they are just ignoring it. ☹️

@jtesta
Copy link
Owner

jtesta commented Jan 22, 2021 via email

@Wibbbs
Copy link

Wibbbs commented Mar 29, 2021

Apparently there is a new beta out today that mentions:

[Windows] Security fix for possible dll load order hijacking

2.0.37 Beta (March 29, 2021)

Any ideas if this is the fix we have been waiting for?

@ElectricityMachine
Copy link

This has not been fixed. I tested it right now on the latest version of GOG Galaxy. I believe another security notice is in order, since it has been over a year and lo and behold it still works.

@jtesta
Copy link
Owner

jtesta commented Sep 24, 2021 via email

@Wibbbs
Copy link

Wibbbs commented Sep 24, 2021

They don’t seem to care to fix this and I unfortunately gave up on galaxy a long time ago and this was a big reason. There were a couple other minor issues that they don’t seem to care to fix so I had to move in. It’s really a shame as the application is super useful otherwise.

Even if you get some more eyes on the issue I would be surprised if it was fixed.

@theAeon
Copy link

theAeon commented Sep 26, 2021

This is truly unbelievable for a company of that size. I bailed a good long while ago for playnite (no regrets) but...how many people are just running around unaware with a wide-open, well-known local privilege escalation just...there?

I figure the odds are high at this point that someone is exploiting this, no?

@ElectricityMachine
Copy link

The odds are extraordinarily high that someone is exploiting this in the wild. Considering it's a very easy attack vector, if you have a malicious program running on your computer with GOG Galaxy 2.0 installed, it's a 2 second injection that grants full administrator privileges.

Like @jtesta said in his original article, "Unfortunately, due to the vulnerabilities I’ve discovered in GalaxyClientService, all user accounts are effectively administrators." This statement is true, and it appears that GOG doesn't care.

I made a Reddit post that gained a decent amount of traction, including a response by a GOG rep. His response was almost identical to the one issued to jtesta, and shows no real danger or concern. They're basically saying "yeah we'll fix it eventually, it's not serious guys don't worry!"

@theAeon
Copy link

theAeon commented Sep 26, 2021

I'm currently sending a message to MITRE to get the version updated on the CVE at the minimum.

"yeah we'll fix it eventually, it's not serious guys don't worry!"

(narrator: they didn't)

@theAeon
Copy link

theAeon commented Sep 26, 2021

Oh, geez, its worse than I thought

in order to use this privilege escalation, attacker would have to already have access to your PC on non-admin account (e.g physically)
we are in progress of fixing the underlying issue

that "e.g. physically" bit is insanely irresponsible.

@theAeon
Copy link

theAeon commented Sep 26, 2021

lmao so apparently there's two more priv. escalation things that they haven't even bothered to address

CVE-2020-15528/CVE-2020-15529

https://daniels-it-blog.blogspot.com/2020/07/gog-galaxy-escalation-of-privileges.html

these are basically the same bug-admittedly slightly less bad as they require user interaction-but good lord what a mess

@ElectricityMachine
Copy link

I'm currently writing a reply to the rep trying to indicate how serious this issue is. Thanks for finding that other privilege escalation issue. I also realized that the service is run with, not administrator, but SYSTEM privileges! This is absolutely ridiculous and insane to me, especially considering it's been over a year.

@theAeon
Copy link

theAeon commented Jan 25, 2022

happy 2022, gog still hasn't fixed their shit

@Wibbbs
Copy link

Wibbbs commented Jan 25, 2022

LOL, yup I have given up on it. Went back to steam and adding non steam shortcuts manually :/

@theAeon
Copy link

theAeon commented Jan 25, 2022

not to shill, but i've been using playnite. does similar stuff w/ integration and also doesn't turn your computer into swiss cheese.

@theAeon
Copy link

theAeon commented Dec 13, 2023

https://securityintelligence.com/x-force/exploiting-gog-galaxy-xpc-service-privilege-escalation-macos/

oh cool it's broken and exploitable on Mac OS as well. 3 years later (and these guys also gave GOG a years notice)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants