Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[dm-cache] When writing the dirty bitset to the metadata device on cl…
…ean shutdown, dirty bits were never being set to clean.

Harmless bug.
  • Loading branch information
jthornber committed Mar 5, 2013
1 parent 6d0b16e commit 6bbc70a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/md/dm-cache-metadata.c
Expand Up @@ -984,7 +984,7 @@ static int __dirty(struct dm_cache_metadata *cmd, dm_cblock_t cblock, bool dirty
/* nothing to be done */
return 0;

value = pack_value(oblock, flags | (dirty ? M_DIRTY : 0));
value = pack_value(oblock, (flags & ~M_DIRTY) | (dirty ? M_DIRTY : 0));
__dm_bless_for_disk(&value);

r = dm_array_set_value(&cmd->info, cmd->root, from_cblock(cblock),
Expand Down

0 comments on commit 6bbc70a

Please sign in to comment.