Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIs it possible to determine slots (in College Admissions Problem) as a vector? #30
Comments
|
That's not possible in the current version of the package. However, it's an easy fix. We would need to change what's happening in lines 293-294 and 339-340 in R/galeShapley.R. There, we're expanding the preference matrices of students and colleges to account for the number of slots. I'll take a look at it. Seems like something we can easily implement. |
|
Thank you very much for your attention! I think to corresponding change a "matrix" to a "list" in this place? https://github.com/jtilly/matchingR/blob/master/R/galeshapley.R#L315 PS Or (without changing the type), only replace the missing value in the res$matched.colleges (at the college with smaller "slots") on Na? |
|
Yes, we need to change the output type. I'm thinking a list is the way to go, because I'd like to reserve 'NA' for colleges with slots that remain unmatched. |
…nd documented. Also needs some checking that slots has the correct size.
|
I think I have a basic version of this working. The code is on a separate branch. Still needs further testing. |
|
Done and merged into master. |
Currently, "slots" is the number of slots that each college has available. But is possible each college may a different number of slots.
Is it possible to change this input parameter of the algorithm?