Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize string_search when all columns = true #46

Closed
jtorjo opened this issue Jan 19, 2016 · 1 comment
Closed

optimize string_search when all columns = true #46

jtorjo opened this issue Jan 19, 2016 · 1 comment

Comments

@jtorjo
Copy link
Owner

jtorjo commented Jan 19, 2016

i should do a search on all the sub_string (line). If that returns any entries, just see that it fully matches a part

actually, this can be optimized quite a bit more - I can do the search directly on the large_string, and infer the lines containing the line from there (I would need to account for things such as case-sensitivity, case-insensitivity, and so on), but that is fine.

if I choose to go this route, I will have to think about it when I use several large string (when I will in fact allow for line_ex and such). So, I have to think of a general way to allow this.

another note: once I find results, i need to double check that the find is indeed correct (since it could be part of the line that is not included in search - such as level and such).

@jtorjo jtorjo added this to the 1.8 milestone Jan 19, 2016
@jtorjo
Copy link
Owner Author

jtorjo commented Jan 20, 2016

This is solved in 1.6.27. See function line.raw_full_msg() - which basically provides the whole message (containing all parts). Combined with the other caching mechanism, this provides close to 5x speed improvements. Pretty good for now

@jtorjo jtorjo closed this as completed Jan 20, 2016
jtorjo added a commit that referenced this issue Jan 20, 2016
- made large_string thread-safe
- large_string : cache last lines
- solved #46 optimize string_search when all columns = true (see
line.raw_full_msg)
- several improvements to search_form (before moving
load_surrounding_rows to a different thread)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant