Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle restore #8

Closed
jtpio opened this issue Nov 17, 2019 · 9 comments
Closed

Handle restore #8

jtpio opened this issue Nov 17, 2019 · 9 comments

Comments

@jtpio
Copy link
Owner

jtpio commented Nov 17, 2019

At the moment the panels are not restored on page refresh.

not-restored

We could transparently use the LayoutRestorer to transparently restore these panels that are added to the shell.

@jtpio
Copy link
Owner Author

jtpio commented Feb 28, 2020

Maybe we could use a similar approach as @saulshanabrook did in https://github.com/Quansight-Labs/jupyter-widgets-takeover, instead of relying on the widget's pWidget.

@saulshanabrook
Copy link

I spoke too soon, unfortunately...

Issue is we don't save the arguments to restorer.restore(tracker, options) anywhere so we have no way of re-restoring widgets later :(

@jtpio
Copy link
Owner Author

jtpio commented Feb 28, 2020

It sounds like it should be doable, but would maybe require writing a custom widget manager though.

@saulshanabrook
Copy link

@jtpio
Copy link
Owner Author

jtpio commented Feb 28, 2020

But it looks functional :)

I guess it would even make sense to be able to remove the chrome in core lab as well.

@jtpio
Copy link
Owner Author

jtpio commented Feb 28, 2020

Ah I see you posted in jupyterlab/jupyterlab#2031 👍

@saulshanabrook
Copy link

Yeah it's functional haha after many tears...

@dsblank
Copy link

dsblank commented Dec 13, 2020

I think this can be closed, now?

@jtpio
Copy link
Owner Author

jtpio commented Dec 14, 2020

Thanks @dsblank. Yes there is now basic support for this using the widget restoring process.

The next steps could be looking into more advanced layouts like in #48, and be able to restore the layout even if the widgets don't exist on the Python side yet (recreating them from a notebook path).

@jtpio jtpio closed this as completed Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants