Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing session information to kernel (fix a commit error in #44) #46

Merged
merged 13 commits into from
Jun 2, 2020

Conversation

TK-21st
Copy link
Contributor

@TK-21st TK-21st commented May 29, 2020

addresses #43.
Sorry I messed up the commits in #44, so here's a new PR from a different branch.

  • exposing the global sessionManager instance to user (app.serviceManager.sessions)
  • function for giving current session to the user
  • Lint
    • ESlint
    • Pylint

@jtpio
Copy link
Owner

jtpio commented May 29, 2020

This is really neat, thanks!

examples/sessions.ipynb Outdated Show resolved Hide resolved
ipylab/sessions.py Outdated Show resolved Hide resolved
src/widgets/sessions.ts Outdated Show resolved Hide resolved
src/widgets/sessions.ts Outdated Show resolved Hide resolved
ipylab/sessions.py Outdated Show resolved Hide resolved
ipylab/sessions.py Outdated Show resolved Hide resolved
@jtpio
Copy link
Owner

jtpio commented May 29, 2020

By the way, we can update the license and the copyright in a separate PR to "ipylab contributors" (to answer the question of this commit: e8b8ea8).

So everyone who contributes keeps the copyright on their contributions.

What do you think?

…t_current_session to asynchronous refresh_session call
@TK-21st
Copy link
Contributor Author

TK-21st commented May 29, 2020

By the way, we can update the license and the copyright in a separate PR to "ipylab contributors" (to answer the question of this commit: e8b8ea8).

So everyone who contributes keeps the copyright on their contributions.

What do you think?

Sure! That'd be lovely!

@jtpio
Copy link
Owner

jtpio commented Jun 2, 2020

Thanks @TK-21st!

@jtpio jtpio merged commit 578675b into jtpio:master Jun 2, 2020
This was referenced Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants