Pass the WidgetManager to the WidgetRenderer #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: martinRenou <martin.renou@gmail.com>
This reverts commit ef54452.
Make the Voila package public
VoilaApp: Fix constructor
Not doing this will make the WidgetRenderer fail to render newly created widgets (In the case of Voilite which dynamically creates new widgets instead of using the build_widgets method)
|
|
martinRenou
commented
Sep 2, 2022
| @@ -42,7 +42,7 @@ export class WidgetManager extends KernelWidgetManager { | |||
| { | |||
| safe: false, | |||
| mimeTypes: [WIDGET_MIMETYPE], | |||
| createRenderer: options => new WidgetRenderer(options) | |||
| createRenderer: options => new WidgetRenderer(options, this as any) | |||
There was a problem hiding this comment.
Using as any because our WidgetManager does not provide all the needed APIs. Would that be a problem @jtpio ?
At least it's not a problem for the WidgetRenderer itself.
There was a problem hiding this comment.
I guess it might, but worth trying it out.
Wondering whether the upstream typings could use LabWidgetManager instead, similar to jupyter-widgets/ipywidgets#3561.
|
Thanks @martinRenou. Sorry I missed this and proceeded with a rebase of voila-dashboards#846 in the meantime to fix some conflicts. So there are some conflicts here as well now. |
martinRenou
force-pushed
the
lab-based
branch
from
39d1541
to
ec40d60
Compare
jtpio
force-pushed
the
lab-based
branch
2 times, most recently
from
8f95dcb
to
3527577
Compare
trungleduc
force-pushed
the
lab-based
branch
2 times, most recently
from
877815b
to
f5995c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not doing this will make the WidgetRenderer fail to render newly created widgets (In the case of Voilite which dynamically creates new widgets instead of using the build_widgets method)