Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

FIX: crash in shell command when ipcluster_dir already exists #200

Merged
merged 1 commit into from

2 participants

@ogrisel

No description provided.

@ogrisel

BTW, is there an easy way to add a non-regression test for this command?

@jtriley jtriley merged commit 326a3bb into from
@ogrisel

Thanks @jtriley. BTW I will soon have a much simpler version of the IPCluster plugin that does not require the SGE queue. It shares some code with the existing plugin but is quite different as well. Any suggestion for the name of the plugin?

@jtriley
Owner

@ogrisel I've been wanting to change the ipcluster plugin to not use SGE at all by default given that the current implementation takes up the entire SGE queue to run IPython parallel. Feel free to submit a pull request for this.

@ogrisel

Alright! Do you want to maintain ipython 0.10 compat or shall I drop it as well?

@ogrisel

I decided to drop the ipython 0.10 compat in #204 to simplify the code and future maintenance of the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 1 deletion.
  1. +2 −1  starcluster/commands/shell.py
View
3  starcluster/commands/shell.py
@@ -109,7 +109,8 @@ def execute(self, args):
'ipcontroller-client.json')
if cl.master_node.ssh.isfile(json):
log.info("Fetching connector file from cluster...")
- os.makedirs(ipcluster_dir)
+ if not os.path.exists(ipcluster_dir):
+ os.makedirs(ipcluster_dir)
cl.master_node.ssh.get(json, local_json)
else:
self.parser.error(
Something went wrong with that request. Please try again.