Added logging of rules to the rack.errors or rack.logger #15

Open
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants
@scottdavis

example output: https://gist.github.com/1163844

Rails does not support env['rack.logger'] in order to get the log messages to show up in rails you need to send messages to env['rack.errors'] which is kind of hacky but i blame this on rails for not following the rack specs recomenations. It will fall back to 'rack.logger' if it exists

@tilsammans

This comment has been minimized.

Show comment Hide comment
@tilsammans

tilsammans Aug 25, 2011

Contributor

This is a great feature, since I'm a little worried other developers working on the app will not be able to discover that rack-rewrite is active and doing its magic.

They will just see the URL redirects happening without anything in routes.rb and get confused :-)

Contributor

tilsammans commented Aug 25, 2011

This is a great feature, since I'm a little worried other developers working on the app will not be able to discover that rack-rewrite is active and doing its magic.

They will just see the URL redirects happening without anything in routes.rb and get confused :-)

@scottdavis

This comment has been minimized.

Show comment Hide comment
@scottdavis

scottdavis Nov 3, 2011

any word on this? are you still actively maintaining this john?

any word on this? are you still actively maintaining this john?

@scottdavis

This comment has been minimized.

Show comment Hide comment
@scottdavis

scottdavis Mar 14, 2012

Im pretty sure he is no longer maintaining this I've tried reaching out to him via twitter with no response

Im pretty sure he is no longer maintaining this I've tried reaching out to him via twitter with no response

@tilsammans

This comment has been minimized.

Show comment Hide comment
@tilsammans

tilsammans Mar 15, 2012

Contributor

I would be fine in forking and maintaining this. What do you think?

Contributor

tilsammans commented Mar 15, 2012

I would be fine in forking and maintaining this. What do you think?

@travisjeffery

This comment has been minimized.

Show comment Hide comment
@travisjeffery

travisjeffery Oct 16, 2012

Collaborator

@scottdavis Hey I'm the new maintainer, would you mind rebasing your changes so everything's up to date?

Collaborator

travisjeffery commented Oct 16, 2012

@scottdavis Hey I'm the new maintainer, would you mind rebasing your changes so everything's up to date?

@scottdavis

This comment has been minimized.

Show comment Hide comment
@scottdavis

scottdavis Oct 16, 2012

No time ATM working on a rather large release of compass

Sent from my iPhone

On Oct 16, 2012, at 5:00 PM, Travis Jeffery notifications@github.com wrote:

@scottdavis Hey I'm the new maintainer, would you mind rebasing your changes so everything's up to date?


Reply to this email directly or view it on GitHub.

No time ATM working on a rather large release of compass

Sent from my iPhone

On Oct 16, 2012, at 5:00 PM, Travis Jeffery notifications@github.com wrote:

@scottdavis Hey I'm the new maintainer, would you mind rebasing your changes so everything's up to date?


Reply to this email directly or view it on GitHub.

@travisjeffery travisjeffery referenced this pull request Jan 9, 2014

Closed

Maintance Help #54

@paulhenrich

This comment has been minimized.

Show comment Hide comment
@paulhenrich

paulhenrich Mar 30, 2014

I'm taking a stab at this in a branch on my fork. Going to try to maintain commit attribution, but I may have to do some manual work on the merge commit, and I will probably bump the dates on the commits.

I'm taking a stab at this in a branch on my fork. Going to try to maintain commit attribution, but I may have to do some manual work on the merge commit, and I will probably bump the dates on the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment