Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ACE frontend to honor the 'Display Line Numbers' setting #29

Closed
wants to merge 3 commits into from

Conversation

attilawagner
Copy link

@attilawagner attilawagner commented Sep 8, 2016

No description provided.

attilawagner added 3 commits Sep 8, 2016
Additional cleanup:
- Renamed keys in the data-config attribute to use camelCase
- Removed unused 'snippet-id' field from the data-config attribute
Only the keys in $data_attrs meant to be updated in the previous commit.
@jtsternberg
Copy link
Owner

@jtsternberg jtsternberg commented Sep 8, 2016

This is not right. It should be changing viewer.data.lineNums to viewer.data.line_nums. I'll push a fix.

@CounterSeal
Copy link

@CounterSeal CounterSeal commented May 15, 2017

Hello. I'm on version 2.1.0 and line numbers still don't seem to appear when the code snippet is displayed in the blog view. Line numbers do show up when editing code snippets in the admin panel though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants