Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot compile the example android app #13

Closed
tf0054 opened this issue May 14, 2017 · 3 comments
Closed

Cannot compile the example android app #13

tf0054 opened this issue May 14, 2017 · 3 comments

Comments

@tf0054
Copy link

tf0054 commented May 14, 2017

Thank you for sharing the module. Its fun!
But unfortunately for making an apk with the latest master banch, I had to have few changes like this.
tf0054@e3cd51a

And I found the change of parameter name and it needed me to apply the according change to react-native-audiowaveform module pulled from npm repo (v1.0.461)
tf0054@e3cd51a#diff-ff34929671c373ab095bcafa91bd46d4

patch -d node_modules/react-native-audiowaveform < react-native-audiowaveform_index_js.diff

Is it possible to add WaveformWrapper.js which is missing? I guess itd the best to sync the example between Android and IOS.

@juananime
Copy link
Owner

Hi dude, I've just added the wrapper file, let me know if that works for you in order to close issue.
Thanks for your feedback mate.

@TryGennai
Copy link

Thank you for adding the file!

I think the changes I have to apply to make the example work would be few now, but am guessing the change of param name in index.android.js and module's index.js would be still necessary.

waveFormStyle.waveColor -> waveFormStyle.rightWaveColor

Also (it isnt serious, but) waveFormStyle.scrubColor wouldnt be used in java codes.

And they lead me to think like the java codes in the master isnt synced with ios codes at the first place.

Am I right? or you are focusing on ios and havent synced android yet?

@juananime
Copy link
Owner

Hi there, I updated the Example folder with working example... sorry for the delay, hope it works. cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants