Findbugs - fix for infinite loops in shopping cart #182

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
1 participant
@ghost

ghost commented Apr 15, 2012

Hi,
Findbugs notified about the infinite loops in these methods.
This is my first interaction with github, so please let me know how I did :-)
Cheers,
Chris

@juanferrub

This comment has been minimized.

Show comment Hide comment
@juanferrub

juanferrub Apr 16, 2012

Owner

Hi Chris! Thanks a lot for your contribution!
For all our commits we have an associated issues.liferay.com issue ticket, so I created one for this (you can see it here - http://issues.liferay.com/browse/LPS-26736)

Apart from that, the commit was perfect, I only renamed the variables so that it's consistent with the rest of the file and I submitted it to Brian Chan (chief architect) to include it on trunk. (You can see the PR here - brianchandotcom#4975)

Thanks for participating in the community and ... keep fixes and improvements coming! :)
Juan Fernández

Owner

juanferrub commented Apr 16, 2012

Hi Chris! Thanks a lot for your contribution!
For all our commits we have an associated issues.liferay.com issue ticket, so I created one for this (you can see it here - http://issues.liferay.com/browse/LPS-26736)

Apart from that, the commit was perfect, I only renamed the variables so that it's consistent with the rest of the file and I submitted it to Brian Chan (chief architect) to include it on trunk. (You can see the PR here - brianchandotcom#4975)

Thanks for participating in the community and ... keep fixes and improvements coming! :)
Juan Fernández

@juanferrub juanferrub closed this Apr 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment