Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail because of changes in flake8 #322

Open
zvyn opened this issue May 13, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@zvyn
Copy link

commented May 13, 2019

Options to solve this:

  1. Ignore W605 invalid escape sequence errors and pin flake8 to the current version
  2. Fix the W605 invalid escape sequence errors and pin flake8 to the current version
  3. Pin flake8 to the last version that worked

I am happy to provide a PR, just let me know which solution you prefer.

@juanifioren

This comment has been minimized.

Copy link
Owner

commented May 15, 2019

Hi @zvyn maybe 2. will be better, what do u think?

zvyn added a commit to zvyn/django-oidc-provider that referenced this issue May 25, 2019

zvyn added a commit to zvyn/django-oidc-provider that referenced this issue May 25, 2019

zvyn added a commit to zvyn/django-oidc-provider that referenced this issue May 25, 2019

zvyn added a commit to zvyn/django-oidc-provider that referenced this issue May 25, 2019

@zvyn

This comment has been minimized.

Copy link
Author

commented May 25, 2019

Sorry for the noise, I branched off of master at first and had to rebase. Doing that I found out that there was nothing left to do but to pin flake8. Anyway: I made a PR to develop now: #323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.