Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We shouldn't mix models without any update. #181

Closed
kumagi opened this issue Nov 22, 2012 · 2 comments
Closed

We shouldn't mix models without any update. #181

kumagi opened this issue Nov 22, 2012 · 2 comments
Assignees
@kumagi
Labels
improvement server
Milestone
0.5.3

Comments

@kumagi
Copy link
Member

kumagi commented Nov 22, 2012

Time threshold mixing seems to be good for cover the case of low update workload.
But it tend to be waste of resource and lock in case of heavy analyze workroad, or massively distributed environment.

How about eliminate mix() when no update is done.
@suma
Copy link
Member

suma commented Nov 22, 2012

👍

We need not make mixer to MIX operation when update_count == 0.

@ghost ghost assigned suma May 28, 2013
@kmaehashi kmaehashi modified the milestones: 0.5.3, Near Future Mar 3, 2014
@kumagi kumagi assigned kumagi and unassigned suma Mar 3, 2014
kumagi pushed a commit that referenced this issue Mar 5, 2014
don't mix when no update observed, fix #181
88cbaf3
@kumagi kumagi mentioned this issue Mar 5, 2014
Merged
suma added a commit that referenced this issue Mar 13, 2014
@suma
Merge pull request #708 from jubatus/feature/dont_mix_without_update
4b33d3a 
don't mix when no update observed, fix #181
@kumagi
Copy link
Member Author

kumagi commented Mar 13, 2014

fixed via #708

@kumagi kumagi closed this as completed Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumagi kumagi

Labels
improvement server
Projects
None yet
Milestone
0.5.3
Development

No branches or pull requests
3 participants
@suma @kumagi @kmaehashi