user friendly message expected for JSON syntax errors #249

kmaehashi opened this Issue Feb 13, 2013 · 1 comment


None yet
2 participants

kmaehashi commented Feb 13, 2013

Jubatus servers, jubaconv, and jubaconfig must catch exception raised from pficommon::text::json and display user-friendly message like "syntax error in configuration: " + e.what().

Currently it just aborts and core dumps.

terminate called after throwing an instance of 'pfi::lang::parse_error'
  what():  <istream>:1:1 invalid char: '#' (U+0023)
zsh: abort (core dumped)  jubaclassifier --configpath invalid.json

y-oda-oni-juba added a commit to y-oda-oni-juba/jubatus that referenced this issue Apr 4, 2013

@ghost ghost assigned y-oda-oni-juba Apr 11, 2013

y-oda-oni-juba added a commit that referenced this issue Apr 18, 2013

Merge pull request #312 from y-oda-oni-juba/develop
user-friendly config error message (#249)

This comment has been minimized.

Show comment Hide comment

kmaehashi Apr 19, 2013


Fixed via #312


kmaehashi commented Apr 19, 2013

Fixed via #312

@kmaehashi kmaehashi closed this Apr 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment