Push-Mixer does not work in NNBased-Recommender #644

Closed
rimms opened this Issue Feb 3, 2014 · 3 comments

Projects

None yet

4 participants

@rimms
Member
rimms commented Feb 3, 2014

When running NNBased-Recommender, specifying --mixer skip_mixer will failed to MIX.

W0203 18:02:52.974720 21170 push_mixer.cpp:296] unsupported method (get_pull_argument_impl) : mix failed

Some mixables which are used in NNBased-Recommender do not support get_pull_argument, push and pull.

@kmaehashi
Member

This also applies for jubaanomaly using light_lof.

weight_manager (recommender & anomaly) and sparse_matrix_storage (recommender) both don't override methods needed for push/pull mixer, although they're in the mixable_holder.

@kmaehashi kmaehashi added this to the Far Future milestone Feb 10, 2014
@kmaehashi kmaehashi assigned beam2d and unnonouno and unassigned beam2d Feb 10, 2014
@kmaehashi
Member

In the meeting on 2014-02-10, we asked @beam2d to list possible solutions.

@kmaehashi kmaehashi added improvement bug and removed bug improvement labels Apr 4, 2014
@kmaehashi
Member

I think this problem is now resolved by the refactoring done in core/server separation.

@kmaehashi kmaehashi closed this Feb 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment