jubaanomaly does not accept add() with light_lof #656

Closed
hido opened this Issue Feb 10, 2014 · 3 comments

2 participants

@hido

As described in #588, lof and light_lof have a difference in anomaly client API.

However, this causes two other problems.

@kmaehashi kmaehashi added this to the 0.5.3 milestone Feb 25, 2014
@hido hido was assigned by kmaehashi Mar 3, 2014
@hido

To solve this problem in 0.5.3 without breaking compatibility, we will add abstraction method to anomaly_base.hpp for switching the behavior in light_lof.cpp and lof.cpp.
From anomaly driver, we will call the abstract method.

To avoid the behavior difference of add for light_lof and lof, we check the existence of id and throw a runtime error when it already exists.

@hido

In #737, anomaly driver checks whether its anomaly model is updatable (of which update_row only works) or not (of which set_row only works).
Though this might not be a good solution, the way add behaves is now consistent for both lof and light_lof. Clearer solution must be done to #588.

I opened another issue to add driver test for light_lof in #738.

@hido hido modified the milestone: Near Future, 0.5.3 Mar 31, 2014
@kumagi kumagi referenced this issue in jubatus/jubatus_core Jun 10, 2014
Merged

add() should be work both lof and light_lof. #9

@kmaehashi
Jubatus member
@kmaehashi kmaehashi closed this Jul 7, 2014
@kmaehashi kmaehashi modified the milestone: 0.6.0, Near Future Jul 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment