Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

recommender: get_all_rows returns rows removed by clear_row #659

Closed
kmaehashi opened this Issue · 4 comments

2 participants

@kmaehashi
Owner

Currently get_all_rows() API returns values from get_all_column_ids() that is implemented in inverted_index_storage.

https://github.com/jubatus/jubatus/blob/0.5.1/jubatus/core/recommender/inverted_index.cpp#L90
https://github.com/jubatus/jubatus/blob/0.5.1/jubatus/core/storage/inverted_index_storage.cpp#L122

inverted_index_storage::get_all_column_ids uses column2norm_, which is not updated on clear_row.

Isn't it better to use row IDs that comes from orig_->get_all_row_ids() for inverted_index?

@kmaehashi kmaehashi self-assigned this
@kmaehashi kmaehashi added this to the Near Future milestone
@kmaehashi
Owner

From discussion in meeting on 2014-02-17:

  • Fix this issue in the way proposed as above.
  • Raise new issue for garbage collection issues regarding columns of inverted_index.
@kmaehashi
Owner

This issue affects not only to inverted_index, but also to bit_index_storage, which is used by minhash and lsh.

@kmaehashi
Owner

I have a fixed version in df8254f (fix-659 branch). However this depends on pull-request #685.

@kmaehashi kmaehashi modified the milestone: 0.5.3, Near Future
@hido
Owner

Since I merged #685, please send a pull-request with fix-659 branch so that I can also review it.

@hido hido closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.