Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Need to increment forgetting weights #691

Closed
unnonouno opened this Issue · 3 comments

2 participants

@unnonouno
Owner

forget_weight is only called when no carry appears. But it's not natural.

https://github.com/jubatus/jubatus/blob/master/jubatus/core/clustering/compressive_storage.cpp#L94

Maybe we need to call forget_weight at the first line of carry_up method.

@unnonouno unnonouno was assigned by kmaehashi
@kmaehashi
Owner

From discussion in meeting in 2014-03-03, we asked @unnonouno to discuss the correctness of the idea with @beam2d.

@unnonouno
Owner

I wrote a test for this issue, and confirmed unexpected behavior of forget_weight. I fixed it with the patch.

@kmaehashi
Owner

Fixed via #704.

@kmaehashi kmaehashi closed this
@kmaehashi kmaehashi added this to the 0.5.4 milestone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.