Need to increment forgetting weights #691

Closed
unnonouno opened this Issue Feb 25, 2014 · 3 comments

Comments

Projects
None yet
2 participants
Owner

unnonouno commented Feb 25, 2014

forget_weight is only called when no carry appears. But it's not natural.

https://github.com/jubatus/jubatus/blob/master/jubatus/core/clustering/compressive_storage.cpp#L94

Maybe we need to call forget_weight at the first line of carry_up method.

@unnonouno unnonouno added bug labels Feb 25, 2014

Owner

kmaehashi commented Mar 3, 2014

From discussion in meeting in 2014-03-03, we asked @unnonouno to discuss the correctness of the idea with @beam2d.

Owner

unnonouno commented Mar 3, 2014

I wrote a test for this issue, and confirmed unexpected behavior of forget_weight. I fixed it with the patch.

Owner

kmaehashi commented Apr 7, 2014

Fixed via #704.

@kmaehashi kmaehashi closed this Apr 7, 2014

@kmaehashi kmaehashi added this to the 0.5.4 milestone Apr 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment