Determine which headers must be available to build user-defined systems #95

Closed
kmaehashi opened this Issue Aug 21, 2012 · 3 comments

Comments

Projects
None yet
1 participant
@kmaehashi
Member

kmaehashi commented Aug 21, 2012

Currently only classifier's headers are installed; we must re-investigate which headers must be available to build user-defined systems, including other engines.

See also: #92

@kmaehashi

This comment has been minimized.

Show comment
Hide comment
@kmaehashi

kmaehashi Apr 7, 2013

Member

core/classifier.hpp includes linear_function_mixer.hpp, mixable_weight_manager.hpp and diffv.hpp, but it is not installed by wscript.

We should resolve these kind of header dependency problems.

Member

kmaehashi commented Apr 7, 2013

core/classifier.hpp includes linear_function_mixer.hpp, mixable_weight_manager.hpp and diffv.hpp, but it is not installed by wscript.

We should resolve these kind of header dependency problems.

@ghost ghost assigned kmaehashi Apr 9, 2013

kmaehashi added a commit that referenced this issue Apr 18, 2013

@kmaehashi

This comment has been minimized.

Show comment
Hide comment
@kmaehashi

kmaehashi Apr 18, 2013

Member

Fixed via 3d2497b.

I've removed zk.hpp and cached_zk.hpp from installation, as it uses ZOOKEEPER_HEADER macro which is set by our wscript.

I close this issue for this time, but we need to continue thinking of what should be provided/exposed to users, in accordance with #250.

Member

kmaehashi commented Apr 18, 2013

Fixed via 3d2497b.

I've removed zk.hpp and cached_zk.hpp from installation, as it uses ZOOKEEPER_HEADER macro which is set by our wscript.

I close this issue for this time, but we need to continue thinking of what should be provided/exposed to users, in accordance with #250.

@kmaehashi kmaehashi closed this Apr 18, 2013

@kmaehashi

This comment has been minimized.

Show comment
Hide comment
@kmaehashi

kmaehashi Apr 18, 2013

Member

I've automated the following test in our CI environment to ensure that there are no missing headers (i.e., to make sure that all header files can be included at once).

PREFIX=/opt/jubatus
find "${PREFIX}/include" -name "*.hpp" -not -path "${PREFIX}/include/jubatus/client*" -printf "#include <%P>\n" | g++ -x c++ -I"${PREFIX}/include" -c -o /dev/null -
Member

kmaehashi commented Apr 18, 2013

I've automated the following test in our CI environment to ensure that there are no missing headers (i.e., to make sure that all header files can be included at once).

PREFIX=/opt/jubatus
find "${PREFIX}/include" -name "*.hpp" -not -path "${PREFIX}/include/jubatus/client*" -printf "#include <%P>\n" | g++ -x c++ -I"${PREFIX}/include" -c -o /dev/null -
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment