Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove free_long and free_double #671

Merged
merged 6 commits into from Apr 7, 2014
Merged

Remove free_long and free_double #671

merged 6 commits into from Apr 7, 2014

Conversation

unnonouno
Copy link
Member

I removed free_long and free_double from weighted_point.
Model file compatibility is broken.


template <typename T>
void sort_by(const std::vector<double>& scores, std::vector<T>& array) {
assert(scores.size() == array.size());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use jubatus/core/common/assert.hpp.

@kmaehashi
Copy link
Member

In the meeting on 2014-02-24, reviewer was not decided.
I've temporarily set the milestone to Near Future as a reminder.

@kmaehashi kmaehashi added this to the Near Future milestone Feb 24, 2014
@kmaehashi
Copy link
Member

Discussion from meeting on 2014-02-24:

  • This pull-req is a improvement to eliminate variables used during calculation.
  • We should note that these variables are currently serialized to the model file. We can pad with dummy variable to keep compatibility.

@unnonouno unnonouno changed the title (WIP) Remove free_long and free_double Remove free_long and free_double Mar 24, 2014
@unnonouno
Copy link
Member Author

related to #662

@kmaehashi kmaehashi self-assigned this Apr 7, 2014
@kmaehashi kmaehashi modified the milestones: 0.5.4, Near Future Apr 7, 2014
kmaehashi added a commit that referenced this pull request Apr 7, 2014
Remove free_long and free_double
@kmaehashi kmaehashi merged commit f1fdcf0 into develop Apr 7, 2014
@kmaehashi kmaehashi deleted the remove_free branch April 7, 2014 08:19
@kmaehashi
Copy link
Member

👍 I confirmed that tests run successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants