fix bit_index_storage to erase rows with empty vector on MIX #685

Merged
merged 2 commits into from Mar 23, 2014

Projects

None yet

3 participants

@kmaehashi
Jubatus member

Fix for #684

@kmaehashi kmaehashi added this to the 0.5.3 milestone Feb 25, 2014
@kmaehashi kmaehashi added the _updated label Feb 25, 2014
@hido hido was assigned by kmaehashi Mar 3, 2014
@kumagi kumagi and 1 other commented on an outdated diff Mar 5, 2014
jubatus/core/storage/bit_index_storage_test.cpp
@@ -137,6 +137,25 @@ bit_vector make_vector(const string& b) {
EXPECT_TRUE(v == make_vector("1100"));
s3.get_row("r4", v);
EXPECT_TRUE(v == bit_vector());
+
+ std::vector<std::string> ids;
@kumagi
kumagi Mar 5, 2014

std:: won't be needed.

@kmaehashi
kmaehashi Mar 6, 2014

I removed it.

@hido

👍 LGTM

NOTE: cpplint errors must be corrected before release.

@hido hido merged commit 5f4029d into develop Mar 23, 2014

1 check passed

Details default The Travis CI build passed
@hido hido deleted the fix-684 branch Mar 23, 2014
@kmaehashi
Jubatus member

Thanks for reviewing!
I'll fix that shortly afterwards > cpplint errors

@kmaehashi
Jubatus member

Fixed cpplint error in 05a4b7e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment