don't mix when no update observed, fix #181 #708

Merged
merged 2 commits into from Mar 13, 2014

Conversation

Projects
None yet
3 participants
Owner

kumagi commented Mar 5, 2014

This PR is correspond to #181

If no update was done, we shouldn't invoke mix.

discussion

  • Push_mixer should invoke mix without observing update.
  • Because every node should propagate update of others.
  • No node could detect the demands of mix without mix.

@kmaehashi kmaehashi added this to the 0.5.3 milestone Mar 10, 2014

- || (0 < tick_threshold_ && new_ticktime - ticktime_ > tick_threshold_)
- ) {
+ if (((0 < count_threshold_ && counter_ >= count_threshold_)
+ || (0 < tick_threshold_ && new_ticktime - ticktime_ > tick_threshold_))
@suma

suma Mar 10, 2014

Owner

Unfortunately, cpplint says this line is too long.

Owner

suma commented Mar 10, 2014

LGTM without cpplint caution.

Owner

kumagi commented Mar 13, 2014

@suma I fixed it.

suma added a commit that referenced this pull request Mar 13, 2014

@suma suma merged commit 4b33d3a into develop Mar 13, 2014

1 check passed

default The Travis CI build passed
Details

@suma suma deleted the feature/dont_mix_without_update branch Mar 13, 2014

Owner

suma commented Mar 13, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment