Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

License timebomb should be a major version #239

Closed
fcanela opened this issue Aug 23, 2018 · 3 comments
Closed

License timebomb should be a major version #239

fcanela opened this issue Aug 23, 2018 · 3 comments

Comments

@fcanela
Copy link

fcanela commented Aug 23, 2018

Hello.

A recent change have made license parameter mandatory since september this month. I think that is a breaking change and could cause projects that are not reviewing non-failing logs to suddently shut down. Please, consider rolling back the 1.x branch to one without timebomb and upgrading major version.

@pickhardt
Copy link
Collaborator

Sure, we can do that. I'll make the latest 1.x version not have a failure mode, and instead push that to a 2.x major version.

@pickhardt
Copy link
Collaborator

Done. Note that a license has been required for over a year and a half, just not enforced in code. So you should still get one. However there's no time bomb as part of the 1.3.1 version. It will be required with the 2.x version after Sep 19.

@fcanela
Copy link
Author

fcanela commented Aug 25, 2018

Thanks, @pickhardt, for understanding and solving the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants