PopupMenu: Avoid potential crash when accessing exitingModalState member

juce-framework · May 5, 2022 · 319da16 · 319da16
1 parent 4805b86
commit 319da16
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/modules/juce_gui_basics/menus/juce_PopupMenu.cpp b/modules/juce_gui_basics/menus/juce_PopupMenu.cpp
@@ -509,10 +509,14 @@ struct MenuWindow  : public Component
             auto resultID = options.hasWatchedComponentBeenDeleted() ? 0 : getResultItemID (item);
 
             exitModalState (resultID);
-            exitingModalState = true;
 
-            if (makeInvisible && deletionChecker != nullptr)
-                setVisible (false);
+            if (deletionChecker != nullptr)
+            {
+                exitingModalState = true;
+
+                if (makeInvisible)
+                    setVisible (false);
+            }
 
             if (resultID != 0
                  && item != nullptr