Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios bluetooth midi dialog crash with "Status bar hidden" enabled #886

Closed
modosc opened this issue Apr 4, 2021 · 3 comments
Closed

ios bluetooth midi dialog crash with "Status bar hidden" enabled #886

modosc opened this issue Apr 4, 2021 · 3 comments

Comments

@modosc
Copy link

modosc commented Apr 4, 2021

this is 100% reproducible with the MidiDemo on ios, make sure you set status bar hidden to enabled. it works fine when status bar hidden is disabled.

it crashes at juce_ios_UIViewComponentPeer.mm#L274

#0	0x00000001d751eb98 in __kill ()
#1	0x0000000101006edc in juce::isKioskModeView(JuceUIViewController*) at /Users/jon/git/JUCE/modules/juce_gui_basics/native/juce_ios_UIViewComponentPeer.mm:274
#2	0x0000000101006de8 in -[JuceUIViewController prefersStatusBarHidden] at /Users/jon/git/JUCE/modules/juce_gui_basics/native/juce_ios_UIViewComponentPeer.mm:330
#3	0x00000001adf5297c in -[UIViewController _preferredStatusBarVisibility] ()
#4	0x00000001adcdcb50 in +[UIWindow(StatusBarManager) _prefersStatusBarHiddenInWindow:targetOrientation:animationProvider:] ()
#5	0x00000001adcdc9d0 in +[UIWindow(StatusBarManager) _prefersStatusBarHiddenInWindow:animationProvider:] ()
#6	0x00000001ae5fe428 in -[UIApplication _isStatusBarEffectivelyHiddenForContentOverlayInsetsForWindow:] ()
#7	0x00000001ae636054 in -[UIWindow _sceneSafeAreaInsetsIncludingStatusBar:] ()
#8	0x00000001ae635c68 in -[UIWindow _normalizedSafeAreaInsets] ()
#9	0x00000001ae635e9c in -[UIWindow safeAreaInsets] ()
#10	0x00000001aead5278 in -[UIView _safeAreaInsetsForFrame:inSuperview:] ()
#11	0x00000001aead5170 in -[UIView _safeAreaInsetsInSuperview:] ()
#12	0x00000001aead5374 in -[UIView _updateSafeAreaInsets] ()
#13	0x00000001aeb00498 in -[UIView(CALayerDelegate) layoutSublayersOfLayer:] ()
#14	0x00000001af005df4 in -[CALayer layoutSublayers] ()
#15	0x00000001af00c398 in CA::Layer::layout_if_needed(CA::Transaction*) ()
#16	0x00000001af0176e8 in CA::Layer::layout_and_display_if_needed(CA::Transaction*) ()
#17	0x00000001aef62d7c in CA::Context::commit_transaction(CA::Transaction*, double, double*) ()
#18	0x00000001aef8cf40 in CA::Transaction::commit() ()
#19	0x00000001ae5f4d8c in _UIApplicationFlushRunLoopCATransactionIfTooLate ()
#20	0x00000001ae69bac4 in __processEventQueue ()
#21	0x00000001ae692afc in __eventFetcherSourceCallback ()
#22	0x00000001abd0bbf0 in __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ ()
#23	0x00000001abd0baf0 in __CFRunLoopDoSource0 ()
#24	0x00000001abd0ae9c in __CFRunLoopDoSources0 ()
#25	0x00000001abd053e0 in __CFRunLoopRun ()
#26	0x00000001abd04ba0 in CFRunLoopRunSpecific ()
#27	0x00000001c2a6a598 in GSEventRunModal ()
#28	0x00000001ae5f62f4 in -[UIApplication _run] ()
#29	0x00000001ae5fb874 in UIApplicationMain ()
#30	0x000000010100ad8c in juce::juce_iOSMain(int, char const**, void*) at /Users/jon/git/JUCE/modules/juce_gui_basics/native/juce_ios_Windowing.mm:427
#31	0x0000000100ee5698 in juce::JUCEApplicationBase::main(int, char const**) at /Users/jon/git/JUCE/modules/juce_events/messages/juce_ApplicationBase.cpp:237
#32	0x0000000100e62e24 in main at /Users/jon/git/MidiDemo/Source/Main.cpp:68

some git bisecting led me to 56f9f83638385cf4700f9840f7917cc67485c3b1 - reverting this change locally fixes the issue for me i was wrong, reverting it shows the midi dialog but the crash still occurs after the midi dialog is closed.

@modosc
Copy link
Author

modosc commented Apr 4, 2021

i cherry-picked 92ca22c from develop and it seems to have solved my problem. not sure if i need to leave this bug open or not - is there a new release coming up?

@ed95
Copy link
Contributor

ed95 commented Apr 6, 2021

As per the issue template, issues should be raised after testing against the latest develop branch since bugs are often already fixed there. This fix will make its way onto the master branch when we next do a release, which is typically every few months.

@ed95 ed95 closed this as completed Apr 6, 2021
@modosc
Copy link
Author

modosc commented Apr 6, 2021

got it, thanks @ed95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants