Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a warning in StaticAnalyzer #106

Merged
merged 1 commit into from Feb 8, 2017
Merged

Conversation

k0kubun
Copy link
Collaborator

@k0kubun k0kubun commented Feb 7, 2017

I fixed a following warning introduced in #95. I hope this will be released as v0.7.8.

temple/lib/temple/filters/static_analyzer.rb:38: warning: assigned but unused variable - col

By the way, Haml's master uses Temple now! 馃嵑

@minad
Copy link
Collaborator

minad commented Feb 7, 2017

Wow, that's cool with haml! Since you are very involved with haml, I would suggest that we add you as a maintainer to temple. What do you think @judofyr?

@judofyr
Copy link
Owner

judofyr commented Feb 7, 2017

@k0kubun Now you have push-access to the repo. Feel free to commit and push smaller improvements as you'd like. Larger changes we can discuss through PRs.

@k0kubun
Copy link
Collaborator Author

k0kubun commented Feb 7, 2017

Thank you! I'll fix Travis failure for now.

@k0kubun k0kubun force-pushed the fix-warnings branch 2 times, most recently from 02d6ad9 to e89ffb3 Compare February 8, 2017 00:32
temple/lib/temple/filters/static_analyzer.rb:38: warning: assigned but unused variable - col
@k0kubun
Copy link
Collaborator Author

k0kubun commented Feb 10, 2017

@judofyr @minad Could you release this change as v0.7.8?

@minad
Copy link
Collaborator

minad commented Feb 10, 2017

Sure, soon. You want the warning fix just as a minor release and the major refactoring in 0.8? I am also fine with you being added to the gem owners.

@k0kubun
Copy link
Collaborator Author

k0kubun commented Feb 10, 2017

You want the warning fix just as a minor release and the major refactoring in 0.8?

Yes. But just releasing 0.8.0 is okay too.

I am also fine with you being added to the gem owners.

That would be very helpful. :)

@k0kubun
Copy link
Collaborator Author

k0kubun commented Feb 10, 2017

Added a commit for a minor release. 8b0912c

Could you add me to gem owners?

@minad
Copy link
Collaborator

minad commented Feb 10, 2017

@k0kubun Please be patient. @judofyr will add you if he agrees.

@k0kubun
Copy link
Collaborator Author

k0kubun commented Feb 10, 2017

馃檱 I'm sorry, waiting for it.

@judofyr
Copy link
Owner

judofyr commented Feb 12, 2017

Merged and released as 0.8.0. I'll add you as gem owners later if it turns out you have lots of changes that needs releases.

@k0kubun
Copy link
Collaborator Author

k0kubun commented Feb 12, 2017

Thank you for releasing them! 馃帀

For now, there are no changes requiring releases. So I'll ask you again later if I have more changes to release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants