New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a warning in StaticAnalyzer #106
Conversation
Wow, that's cool with haml! Since you are very involved with haml, I would suggest that we add you as a maintainer to temple. What do you think @judofyr? |
@k0kubun Now you have push-access to the repo. Feel free to commit and push smaller improvements as you'd like. Larger changes we can discuss through PRs. |
Thank you! I'll fix Travis failure for now. |
02d6ad9
to
e89ffb3
Compare
temple/lib/temple/filters/static_analyzer.rb:38: warning: assigned but unused variable - col
Sure, soon. You want the warning fix just as a minor release and the major refactoring in 0.8? I am also fine with you being added to the gem owners. |
Yes. But just releasing 0.8.0 is okay too.
That would be very helpful. :) |
Added a commit for a minor release. 8b0912c Could you add me to gem owners? |
馃檱 I'm sorry, waiting for it. |
Merged and released as 0.8.0. I'll add you as gem owners later if it turns out you have lots of changes that needs releases. |
Thank you for releasing them! 馃帀 For now, there are no changes requiring releases. So I'll ask you again later if I have more changes to release. |
I fixed a following warning introduced in #95. I hope this will be released as v0.7.8.
By the way, Haml's master uses Temple now! 馃嵑