Permalink
Browse files

Change property names based on code review

Podcast is now IsPodcast, and the other properties have been prefixed with Podcast.
  • Loading branch information...
1 parent 4a6a985 commit 23f7906256c513794680ab06192a2cca01861aaa @kiliman kiliman committed May 11, 2011
Oops, something went wrong.
@@ -140,8 +140,8 @@ public void LoadFile(string path)
cmbGenre.Text = _id3v2.Genre;
txtYear.Text = _id3v2.Year;
txtTrackNumber.Text = _id3v2.TrackNumber;
- chkPodcast.Checked = _id3v2.Podcast;
- txtFeedUrl.Text = _id3v2.PodcastFeedUrl;
+ chkPodcast.Checked = _id3v2.IsPodcast;
+ txtPodcastFeedUrl.Text = _id3v2.PodcastFeedUrl;
BindingSource bindingSource = new BindingSource();
imageBindingNavigator.BindingSource = bindingSource;
@@ -211,8 +211,8 @@ public void SaveFile(string path)
_id3v2.Genre = cmbGenre.Text;
_id3v2.Year = txtYear.Text;
_id3v2.TrackNumber = txtTrackNumber.Text;
- _id3v2.Podcast = chkPodcast.Checked;
- _id3v2.PodcastFeedUrl = txtFeedUrl.Text;
+ _id3v2.IsPodcast = chkPodcast.Checked;
+ _id3v2.PodcastFeedUrl = txtPodcastFeedUrl.Text;
_id3v2.Save(path);
}
@@ -64,7 +64,7 @@ public abstract partial class FrameContainer : IFrameContainer
private readonly SynchronizedTempoCodes m_SynchronizedTempoCodes;
private readonly AudioSeekPointIndex m_AudioSeekPointIndex;
private readonly PlayCount m_PlayCount;
- private readonly Podcast m_Podcast;
+ private readonly Podcast m_IsPodcast;
private readonly IUrlFrame m_AudioFileUrl;
private readonly IUrlFrame m_AudioSourceUrl;
@@ -123,9 +123,9 @@ public abstract partial class FrameContainer : IFrameContainer
private readonly TextFrame m_TitleSortOrder;
private readonly TextFrame m_ProducedNotice;
private readonly TextFrame m_SetSubtitle;
- private readonly TextFrame m_SeriesCategory;
- private readonly TextFrame m_EpisodeDescription;
- private readonly TextFrame m_EpisodeUrl;
+ private readonly TextFrame m_PodcastSeriesCategory;
+ private readonly TextFrame m_PodcastEpisodeDescription;
+ private readonly TextFrame m_PodcastEpisodeUrl;
private readonly TextFrame m_PodcastFeedUrl;
@@ -273,9 +273,9 @@ internal FrameContainer()
m_ProducedNotice = CreateTextFrame("TPRO", "TPRO", null, "ProducedNotice", null/*todo - same as copyright validation*/);
// Technically only supported in ID3v2.4, but some ID3v2.3 implementations use this frame
m_SetSubtitle = CreateTextFrame("TSST", "TSST", null, "SetSubtitle", null);
- m_SeriesCategory = CreateTextFrame("TCAT", "TCAT", null, "SeriesCategory", null);
- m_EpisodeDescription = CreateTextFrame("TDES", "TDES", null, "EpisodeDescription", null);
- m_EpisodeUrl = CreateTextFrame("TGID", "TGID", null, "EpisodeUrl", null);
+ m_PodcastSeriesCategory = CreateTextFrame("TCAT", "TCAT", null, "SeriesCategory", null);
+ m_PodcastEpisodeDescription = CreateTextFrame("TDES", "TDES", null, "EpisodeDescription", null);
+ m_PodcastEpisodeUrl = CreateTextFrame("TGID", "TGID", null, "EpisodeUrl", null);
m_PodcastFeedUrl = CreateTextFrame("WFED", "WFED", null, "PodcastFeedUrl", null);
m_PositionSynchronization = CreatePositionSynchronizationFrame("POSS", "POSS", null, "PositionSynchronization", null);
@@ -293,7 +293,7 @@ internal FrameContainer()
m_MusicianCreditsList = CreateMusicianCreditsListFrame("TMCL", "TMCL", null, "MusicianCreditsList", null);
m_AudioSeekPointIndex = CreateAudioSeekPointIndexFrame("ASPI", "ASPI", null, "AudioSeekPointIndex", null);
m_PlayCount = CreateFrame<PlayCount>("PCNT", "PCNT", "CNT", "PlayCount");
- m_Podcast = CreateFrame<Podcast>("PCST", "PCST", "PCS", "Podcast");
+ m_IsPodcast = CreateFrame<Podcast>("PCST", "PCST", "PCS", "Podcast");
// TODO: TYER->TDRL, TDAT,TIME->TDRC (in setters, not here)
@@ -754,10 +754,10 @@ public IPlayCount PlayCount
/// Gets or sets if podcast
/// </summary>
/// <value>True if podcast.</value>
- public bool Podcast
+ public bool IsPodcast
{
- get { return m_Podcast.Value; }
- set { m_Podcast.Value = value; }
+ get { return m_IsPodcast.Value; }
+ set { m_IsPodcast.Value = value; }
}
/// <summary>
@@ -1061,10 +1061,10 @@ public string SetSubtitle
/// <value>
/// The series category. TCAT
/// </value>
- public string SeriesCategory
+ public string PodcastSeriesCategory
{
- get { return m_SeriesCategory.Value; }
- set { m_SeriesCategory.Value = value; }
+ get { return m_PodcastSeriesCategory.Value; }
+ set { m_PodcastSeriesCategory.Value = value; }
}
/// <summary>
@@ -1074,10 +1074,10 @@ public string SeriesCategory
/// <value>
/// The episode description. TDES
/// </value>
- public string EpisodeDescription
+ public string PodcastEpisodeDescription
{
- get { return m_EpisodeDescription.Value; }
- set { m_EpisodeDescription.Value = value; }
+ get { return m_PodcastEpisodeDescription.Value; }
+ set { m_PodcastEpisodeDescription.Value = value; }
}
/// <summary>
@@ -1087,10 +1087,10 @@ public string EpisodeDescription
/// <value>
/// The episode description. TGID
/// </value>
- public string EpisodeUrl
+ public string PodcastEpisodeUrl
{
- get { return m_EpisodeUrl.Value; }
- set { m_EpisodeUrl.Value = value; }
+ get { return m_PodcastEpisodeUrl.Value; }
+ set { m_PodcastEpisodeUrl.Value = value; }
}
/// <summary>
@@ -479,7 +479,7 @@ public interface IFrameContainer : INotifyPropertyChanged, INotifyInvalidData
/// Gets or sets if podcast.
/// </summary>
/// <value>True if podcast.</value>
- bool Podcast { get; set; }
+ bool IsPodcast { get; set; }
/// <summary>
/// Gets the BindingList of popularimeter frames.
@@ -616,7 +616,7 @@ public interface IFrameContainer : INotifyPropertyChanged, INotifyInvalidData
/// <value>
/// The series category. TCAT
/// </value>
- string SeriesCategory { get; set; }
+ string PodcastSeriesCategory { get; set; }
/// <summary>
/// Gets or sets the episode description. Used for iTunes Podcasts.
@@ -625,7 +625,7 @@ public interface IFrameContainer : INotifyPropertyChanged, INotifyInvalidData
/// <value>
/// The episode description. TDES
/// </value>
- string EpisodeDescription { get; set; }
+ string PodcastEpisodeDescription { get; set; }
/// <summary>
/// Gets or sets the episode URL. Used for iTunes Podcasts.
@@ -634,7 +634,7 @@ public interface IFrameContainer : INotifyPropertyChanged, INotifyInvalidData
/// <value>
/// The episode description. TGID
/// </value>
- string EpisodeUrl { get; set; }
+ string PodcastEpisodeUrl { get; set; }
/// <summary>
/// Gets or sets the podcast feed URL. Used in iTunes Podcasts. WFED.

0 comments on commit 23f7906

Please sign in to comment.