Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message finalzier support #39

Closed

Conversation

crazybert
Copy link

Finalizer is fired on success and final retry

New interfaces:
IFinalizeMessages
IMessageFinalizerProvider

@judwhite
Copy link
Owner

Can you explain the use case? We can talk offline this week and I'll update the PR with relevant info.

@judwhite
Copy link
Owner

The nsqjs library has a DISCARD handler, maybe we could do something like this.

The IMessageAuditor handles these cases but:

  • The naming doesn't make it obvious.
  • You need to bring your own plumbing if you want to do custom success/final failure handling based on topic.

I kind of get the final failure handling, but what's the use case for success? Is it to support sagas?

@crazybert crazybert closed this Jul 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants