Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 20 #31

Merged
merged 3 commits into from
Sep 10, 2019
Merged

Issue 20 #31

merged 3 commits into from
Sep 10, 2019

Conversation

turekg
Copy link
Contributor

@turekg turekg commented Aug 30, 2019

Ready to merge, works with Tensorflow 1.14 and CSBDeep 0.4.0.

Copy link
Collaborator

@tibuch tibuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it with python 3.7 and tensorflow-gpu==1.14 and it works. Additionally I tested python 3.6 and tensorflow-gpu==1.12 and this works too.

Could you add this information to the readme and also include this configuration in the travis.yml file?

Thank you for refactoring and making N2V compatible with csbdeep-0.4.0!

README.md Show resolved Hide resolved
@turekg turekg force-pushed the issue_20 branch 2 times, most recently from 50d3d6e to 31b468a Compare September 4, 2019 11:58
@tibuch
Copy link
Collaborator

tibuch commented Sep 6, 2019

All fixes regarding #20 are in place. Thank you @turekg !

In discussions with @alex-krull and @fjug we figured out that we also need channel-wise normalization #32 and a super-conservative mode #33 could be beneficial.

@fjug and I will work on that next week.

I think it makes sense to add these features/fixes also to this PR and then make one new release with all changes. Object if you think otherwise :)

@tibuch
Copy link
Collaborator

tibuch commented Sep 10, 2019

I just read about short change logs/PRs. Since #32 and #33 have nothing to do with #20 I will merge this PR and release N2V v0.1.7.

Thank you @turekg for the PR.

@tibuch tibuch merged commit 2326bb6 into master Sep 10, 2019
@tibuch tibuch deleted the issue_20 branch September 12, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants