Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

tinyurl plugin: bit.ly breaks when & symbol is in url #101

Open
ghost opened this Issue Nov 17, 2009 · 1 comment

Comments

Projects
None yet
1 participant
@ghost

ghost commented Nov 17, 2009

When I tried to submit this ebay url:
http://cgi.ebay.co.uk/ws/eBayISAPI.dll?ViewItem&item=220509703021&ssPageName=STRK:MEWAX:IT

The returned bit.ly url linked to:
http://cgi.ebay.co.uk/ws/eBayISAPI.dll?ViewItem

I'm not sure if this is a problem with the tinyurl plugin or the bit.ly api itself.

Collaborator

BanzaiMan commented Nov 25, 2009

Currently, tinyurl plugin uses URI.escape to pass your URL to bit.ly. URI.escape does not escape '?', while CGI.escape does. Changing this appears to fix your particular case, but I am not sure if that is universally acceptable fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment