Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Kafka bind address puppet #27
Conversation
petevg
added some commits
Jul 19, 2016
|
i don't understand why this is needed if juju-solutions/layer-apache-bigtop-base#32 is in... Isn't this duplicating that functionality? |
johnsca
reviewed
Jul 22, 2016
| @@ -25,7 +25,11 @@ broker.id=<%= @broker_id %> | ||
| port=<%= @port %> | ||
| # Hostname the broker will bind to. If not set, the server will bind to all interfaces | ||
| +<% if !@bind_addr.nil? && !@bind_addr.empty? %> | ||
| +host.name=<%= @bind_addr %> |
johnsca
Jul 22, 2016
Owner
host.name is deprecated in favor of listeners in the latest release of Kakfa (0.10.0). This is fine for now, as Bigtop is using 0.8.1, but it's something to keep in mind for the future.
johnsca
reviewed
Jul 22, 2016
| @@ -191,6 +191,7 @@ hadoop::common::tez_jars: "/usr/lib/tez" | ||
| #kafka | ||
| kafka::server::port: "9092" | ||
| kafka::server::zookeeper_connection_string: "%{hiera('bigtop::hadoop_head_node')}:2181" | ||
| +kafka::server::bind_addr: "" |
petevg
Jul 22, 2016
@johnsca What are we supposed to do instead? Do we just leave the value out of cluster.yaml?
|
@kwmonroe juju-solutions/layer-apache-bigtop-base#32 adds a post-deploy patch so that the charm can have this option available when deploying Apache Bigtop 1.1.0, while this PR requests that the option be added to Bigtop itself so that it is available, without a post-deploy patch, in subsequent releases (1.2.0+). Clearly it's not ideal to apply patches post-deploy, but the alternative is for the charms to not be able to deploy 1.1.0 at all. The patches are a compromise. We should add documentation to bigtop-packages/src/charm/README.md clearly spelling out what patches are applied post-deployment for each Bigtop release (linking to the Jira tickets) and why. |
|
This PR should be against the upstream and follow the patch process outlined in the wiki. We also need to update the apache-bigtop-base layer since this was updated after juju-solutions/layer-apache-bigtop-base#32 was merged. |
petevg
commented
Jul 25, 2016
|
Submitted upstream. |
petevg commentedJul 21, 2016
@juju-solutions/bigdata
This is one of three pull requests for setting up the ability to bind kafka to an interface/ip address. I've run bundletester with the following permutations of 'bind_addr' in config.yaml:
My juju fu is not strong enough to setup a second interface on a machine and bind to that, but the above three tests do seem to indicate that the code does what I think that it does.
As part of this work, I also fixed up the kafka tests. It should be easy to get them to run, even if you aren't paying attention to anything other than having the right branch of layer-apache-bigtop-base checked out locally. (The branch is 'kafka-bind-address', incidentally)