/bigtop forked from apache/bigtop

Zookeeper bind address #30

Merged
merged 4 commits into from Jul 26, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@petevg @kwmonroe
@petevg

petevg commented Jul 26, 2016 •
Edited 1 time

These are fixes to Zookeeper, which do two things:

  1. Allow an operator to restrict the interface/ip that the client listens on, in secure environments.
  2. Sets the series to xenial, so that we can promulgate to the store without clobbering things.

This is the first PR in a chain of three. The next PR is against upstream master, and implements puppet fixes to support our changes: https://github.com/apache/bigtop/pull/135/files

The last PR in the chain is the patch to the bigtop base layer, which also contains a fix for installing the bigtop zookeeper deb on xenial: juju-solutions/layer-apache-bigtop-base#33

petevg added some commits Jul 22, 2016

@petevg
Added ability to specify an interface to bind the client to. 
Helps users who want to restrict Zookeeper to communicating with the
outside world on a specific ip or interface.
c7eccca
@petevg
Fixed relation name. (Was zkclient after all -- my bad)
7ca4750
@petevg
Renamed client_port_bind_address -> client_bind_addr 
Makes it a bit more consistent with our other naming conventions.
8b2c43b
@petevg
Updated Zookeeper charm to use xenial. 
charm proof was unhappy about the null value for client_bind_addr when
run on the xenial charm. Updated it to an empty string (which will work
the same way in the code), and things were happier.
0a4fecf
@kwmonroe
Member

kwmonroe commented Jul 26, 2016

LGTM

@kwmonroe kwmonroe merged commit 5770e1d into BIGTOP-2476-zookeeper Jul 26, 2016

@kwmonroe
Member

kwmonroe commented Jul 26, 2016

fwiw, also merged the 3rd PR referenced here (juju-solutions/layer-apache-bigtop-base#33). the upstream PR needs some ack from upstreams, but that won't block us from providing this functionality in our zk charm.

@kwmonroe kwmonroe deleted the zookeeper-bind-address branch Aug 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment