This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Cleaning up "loose ends" from previous PR. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added documentation on the network_interface config value to README, added tests, and made the way that variables get passed to configure_kafka more consistent.
| and then running "juju resolved" on each unit: | ||
|
|
||
| juju set-config kafka network_interface=eth0 | ||
| juju resolved kafka/0 |
There was a problem hiding this comment.
As with the zk charm, instructions should say resolved -r to retry the failed hook. Without -r, config-changed will not re-run.
Without -r flag, hook won't auto retry.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation on the network_interface config value to README,
added tests, and made the way that variables get passed to
configure_kafka more consistent.
@juju-solutions/bigdata