New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateAddonsTactic is too verbose #169

Closed
Cynerva opened this Issue Jan 3, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@Cynerva
Copy link
Contributor

Cynerva commented Jan 3, 2017

Per suggestion in juju-solutions/kubernetes#94, we should pipe the git clone and file copy output to DEBUG.

build: Composing into /home/ubuntu/charms
build: Destination charm directory: /home/ubuntu/charms/builds/kubernetes-master
build: Processing layer: layer:basic
build: Processing layer: layer:tls-client
build: Processing layer: layer:debug
build: Processing layer: kubernetes-master (from .)
build: Processing interface: tls-certificates
build: Processing interface: etcd
build: Processing interface: http
build: Processing interface: kubernetes-cni
build: Processing interface: kube-dns
build: Processing interface: ceph-admin
build: Processing interface: public-address
Cleaning /home/ubuntu/charms/builds/kubernetes-master/templates/addons
Cloning https://github.com/kubernetes/kubernetes.git
Cloning into '/tmp/kubernetesZpl0Cy'...
remote: Counting objects: 13345, done.
remote: Compressing objects: 100% (10831/10831), done.
remote: Total 13345 (delta 3870), reused 8271 (delta 1870), pack-reused 0
Receiving objects: 100% (13345/13345), 20.26 MiB | 11.42 MiB/s, done.
Resolving deltas: 100% (3870/3870), done.
Checking connectivity... done.
'/tmp/kubernetesZpl0Cy/cluster/addons/dashboard/dashboard-controller.yaml' -> '/home/ubuntu/charms/builds/kubernetes-master/templates/addons/dashboard-controller.yaml'
'/tmp/kubernetesZpl0Cy/cluster/addons/dashboard/dashboard-service.yaml' -> '/home/ubuntu/charms/builds/kubernetes-master/templates/addons/dashboard-service.yaml'
'/tmp/kubernetesZpl0Cy/cluster/addons/dns/kubedns-controller.yaml.in' -> '/home/ubuntu/charms/builds/kubernetes-master/templates/addons/kubedns-controller.yaml'
'/tmp/kubernetesZpl0Cy/cluster/addons/dns/kubedns-svc.yaml.in' -> '/home/ubuntu/charms/builds/kubernetes-master/templates/addons/kubedns-svc.yaml'
'/tmp/kubernetesZpl0Cy/cluster/addons/cluster-monitoring/influxdb/grafana-service.yaml' -> '/home/ubuntu/charms/builds/kubernetes-master/templates/addons/grafana-service.yaml'
'/tmp/kubernetesZpl0Cy/cluster/addons/cluster-monitoring/influxdb/heapster-controller.yaml' -> '/home/ubuntu/charms/builds/kubernetes-master/templates/addons/heapster-controller.yaml'
'/tmp/kubernetesZpl0Cy/cluster/addons/cluster-monitoring/influxdb/heapster-service.yaml' -> '/home/ubuntu/charms/builds/kubernetes-master/templates/addons/heapster-service.yaml'
'/tmp/kubernetesZpl0Cy/cluster/addons/cluster-monitoring/influxdb/influxdb-grafana-controller.yaml' -> '/home/ubuntu/charms/builds/kubernetes-master/templates/addons/influxdb-grafana-controller.yaml'
'/tmp/kubernetesZpl0Cy/cluster/addons/cluster-monitoring/influxdb/influxdb-service.yaml' -> '/home/ubuntu/charms/builds/kubernetes-master/templates/addons/influxdb-service.yaml'
build: 
build: ---------------------------------------
build:               Build Report
build: ---------------------------------------
build:    tactics/update_addons.py
proof: OK!
@mbruzek

This comment has been minimized.

Copy link
Contributor

mbruzek commented Jan 3, 2017

Thanks for breaking this out into another issue. I am OK with moving the verbosity as is to DEBUG, but I have another suggestion/idea.

  • Suppress all this output.
  • Create a string message (possibly to debug) where the original file is from and where it is copied to. Such as:

Copying dashboard-controller.yaml from github.com/kubernetes/kubernetes.git to kubernetes-master/templates/addons/dashboard-controller.yaml

My point is I just want to know that the build process is taking files not in the current filesystem or repository and copying them to the built charm. You can use full paths or whatever I just want it clear where the file is coming from and where it is going and it is not obvious in the current output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment