Wait for microk8s storage to fully come up before bootstrapping #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microk8s.status --wait-ready doesn't give sufficient information about storage status, so we wait specifically for the StorageClass to exist before proceeding with bootstrap. Also introduces function to handle waiting for command to become ready.
knkski
requested review from
johnsca,
tvansteenburgh and
wallyworld
as code owners
tvansteenburgh
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microk8s.status --wait-ready doesn't give sufficient information about storage status, so we wait specifically for the StorageClass to exist before proceeding with bootstrap.
Also introduces function to handle waiting for command to become ready.