bundletester not calling dependent make targets for make lint

[chuckbutler]

In the flannel docker charm - there is a dependent make target which installs the VENV and sets up ansible playbook linting.

The format of the Makefile is as follows:

virtualenv: .venv/bin/python                                                                                                                                   
.venv/bin/python:                                                                                                                                              
    virtualenv .venv                                                                                                                                           
    .venv/bin/pip install nose flake8 mock pyyaml charmhelpers ansible-lint ansible                                                                            

lint:.venv/bin/python                                                                                                                                          
    @echo Linting Charm                                                                                                                                        
    @charm proof                                                                                                                                               
    @echo Linting Ansible Routines                                                                                                                             
    @.venv/bin/ansible-lint playbooks/* 

When executing via bundletester, it does not actually fire off the dependent job of :.venv/bin/python with the output:

FAIL: flannel-docker::make lint
[/usr/bin/make -s lint          exit 2]
Linting Charm
I: missing recommended hook start
I: File config.yaml not found.
Linting Ansible Routines
/bin/sh: 1: .venv/bin/ansible-lint: not found
make: *** [lint] Error 127

When executing /usr/bin/make -s lint - it does call the dependent job, and can be verified with no .venv directory present in the charm.

[johnsca]

A work-around is to change the dependent make target to just ".venv" (i.e., remove slashes and dashes) but that still doesn't explain why it works when manually running make and not bundletester.

[tvansteenburgh]

The problem is that bundletester makes its own venv by default, which happens to be named '.venv', so from make's perspective, that target is already satisfied, and it doesn't install your deps.

The way forward is to include a tests/tests.yaml containing virtualenv: false so that bundletester doesn't create it's own venv.

We should probably change this default (see #16).