Adds login method and refactors run

[chuckbutler]

No description provided.

[chuckbutler]

@marcoceppi Can I get a 🚢 on this?

or @AdamIsrael @tvansteenburgh @mbruzek

[chuckbutler]

With the new comments, the doc came out pretty nice too

CLASSES
    Docker

    class Docker
     |  Wrapper class to communicate with the Docker daemon on behalf of
     |  a charmer. Provides stateless operations of a running docker daemon
     |
     |  Methods defined here:
     |
     |  __init__(self, socket='unix:///var/run/docker.sock', workspace=None)
     |      @param socket - URI to the Docker daemon socket
     |          default: unix://var/run/docker.sock
     |
     |      @param workspace - Path to directory containing a Dockerfile
     |          default: None
     |
     |  login(self, user, password, email)
     |      Docker login exposed as a method.
     |
     |      @param user - Username in the registry
     |      @param password - Password for the registry
     |      @param email - Email address on account (dockerhub)
     |
     |  ps(self)
     |      return a string of docker status output
     |
     |  run(self, image, options=[], commands=[], arg=[])
     |      Docker Run exposed as a method. This wont be as natural as the
     |      command line docker experience.
     |
     |      Docker CLI output example:
     |      Usage:  docker run [OPTIONS] IMAGE [COMMAND] [ARG...]
     |
     |      @param image - string of the container to pull from the registry,
     |                      eg: ubuntu:latest
     |      @param options - array of string  options, eg: ['-d', '-v /tmp:/tmp']
     |      @param commands - array of string commands, eg: ['ls']
     |      @param arg - array of string command args, eg: ['-al']
     |
     |  running(self)
     |      Predicate method to determine if the daemon we are talking to is
     |      actually online and recieving events.
     |
     |      ex: bootstrap = Docker(socket="unix://var/run/docker-boostrap.sock")
     |      bootstrap.running()
     |      > True

[BillWatts]

👍

[mbruzek]

Commands is an array? Can you give the docker images more than one command? From the usage it looks like just one command.

[mbruzek]

Should we call the login command in an try/catch so that failed login does not exit the python program? It is fine for now but a possible future improvement.

[mbruzek]

I had a few minor questions but nothing blocking this excellent, docstringed code from landing in the upstream. Thanks for making these classes and tests!

[marcoceppi]

⛵️