"state" is too ambiguous/overloaded, should use flag

[marcoceppi]

state, for those new to juju is confusing as it gives the impression you're impacting the Juju state when it's actually the unit state and a state that's rather shallow at the end of the day. It's also very similar to status which brings more confusion.

The suggestion was to use the word "flag" instead which doesn't have as much meaning across domains as state and can be used to better represent (and ties in nicely to @when/@when_not).

The changes would be

set_state -> set_flag
remove_state -> remove_flag

[johnsca]

@bcsaller

[johnsca]

In particular, it seems that people find set_state and status_set confusing, which is understandable, especially if they're both imported as bare identifiers.

[marcoceppi]

updates original description

[chuckbutler]

@johnsca when you say bare identifiers, are you referring to the following?

from charms.reactive import set_state
from charmhelpers.core.hookenv import status_set

# The above make bare identifiers

[marcoceppi]

Yes

On Wed, Jun 29, 2016, 4:09 PM Charles Butler notifications@github.com
wrote:

@johnsca https://github.com/johnsca when you say bare identifiers, are
you referring to the following?

from charms.reactive import set_statefrom charmhelpers.core.hookenv import status_set

The above make bare identifiers

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#76 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAET1T-qhXbE2cbD5RU9i1_fOUkMDEWvks5qQnyngaJpZM4JBB3M
.