/charms.reactive

Add @when_any and @when_not_all decorators #56

Merged
merged 1 commit into from Mar 2, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@johnsca @bcsaller @chuckbutler
@johnsca
Owner

johnsca commented Mar 1, 2016

No description provided.

tests/test_helpers.py
@@ -222,6 +222,29 @@ def test__when_all(self):
self.kv.set('reactive.dispatch.phase', 'other')
assert test(), 'when_all: other; both'
+ def test__when_any(self):
@bcsaller

bcsaller Mar 1, 2016

Contributor

Is there a reason some of the tests have double under test__ prefixes?

@johnsca

johnsca Mar 1, 2016

Owner

The function being tested is _when_any but it's not strictly necessary.

@bcsaller
Contributor

bcsaller commented Mar 1, 2016

LGTM, thanks
@chuckbutler
Contributor

chuckbutler commented Mar 2, 2016

+1 LGTM -- however I have only run the tests, ymmv

johnsca added a commit that referenced this pull request Mar 2, 2016

@johnsca
Merge pull request #56 from johnsca/when_any 
Add @when_any and @when_not_all decorators
caf805b

@johnsca johnsca merged commit caf805b into juju-solutions:master Mar 2, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment