/charms.reactive

Non-None default in toggle_state to mean "toggle" #71

Merged
merged 1 commit into from Jun 15, 2016
+15 −6

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  0.4.4
3 participants
@johnsca @kwmonroe @stub42
@johnsca
Owner

johnsca commented Jun 14, 2016

Fixes #70

@johnsca johnsca added this to the 0.4.4 milestone Jun 15, 2016

@kwmonroe
Member

kwmonroe commented Jun 15, 2016

There was some chatter on #juju about not using a string representation for toggle (instead using object()). I'm fine with this as-in, or with that changed.
@stub42
Collaborator

stub42 commented Jun 15, 2016

This needs a test, which I suspect is trivial.
@johnsca
Owner

johnsca commented Jun 15, 2016

Updated with object() and test.
@stub42
Collaborator

stub42 commented Jun 15, 2016

⛵️ 👍 🍆

@kwmonroe kwmonroe merged commit 6724da9 into juju-solutions:master Jun 15, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment