Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
TLS Termination Support #2
Conversation
chuckbutler
added some commits
Jun 15, 2016
|
From a perfunctory review, I'd say the code is fine. Is there a way to add unit tests to an interface, or would we need a charm/layer to exercise this functionality? |
|
I think in this particular case we'll need a charm, and will need bundle tests. This is a prelim submission for Tigra (formerly Calico) - who is the primary stakeholder behind the etcd-proxy interface currently. I'm only aware of their charm using it, and it carries with it an openstack + neutron dependency. A bit heavy handed for a test. We can probably shape something up similar to validate data sent on the wire with a dummy charm. |
chuckbutler
merged commit 25684ce
into
juju-solutions:master
Jun 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
chuckbutler commentedJun 15, 2016
•
Edited 1 time
-
chuckbutler
Jun 15, 2016